Skip to content

feat: forward product custom attributes #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2025
Merged

feat: forward product custom attributes #30

merged 1 commit into from
Jan 24, 2025

Conversation

mmustafa-tse
Copy link
Contributor

@mmustafa-tse mmustafa-tse commented Jan 15, 2025 •
edited
Loading

Summary

  • A customer raised an issue that we don't forward product custom attributes to GA4/Firebase, after further investigation, I was able to verify that Google accept mapped custom attributes as mentioned here

Testing Plan

  • [Y] Was this tested locally? If not, explain why.
  • Unit tested and E2E tested (it takes 24 hours for results to show in Firebase for this case, breakpoints were showing to be forwarded as expected and will double verify tomorrow in GA4 dashboard)

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

BrandonStalnaker
BrandonStalnaker approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit 0429af8 into mparticle-integrations:development Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

@einsteinx2 einsteinx2 Awaiting requested review from einsteinx2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmustafa-tse @BrandonStalnaker